Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LwHttp incorrect HTTP headers #460

Closed
ale5000-git opened this issue Dec 25, 2017 · 2 comments
Closed

LwHttp incorrect HTTP headers #460

ale5000-git opened this issue Dec 25, 2017 · 2 comments
Labels
bug
Milestone
0.9.1

Comments

@ale5000-git
Copy link

ale5000-git commented Dec 25, 2017 •
edited
Loading

@devemux86

Hi,
all HTTP header lines must be terminated by a carriage return (\r) and a line feed (\n).

You are using only line feed here; could you please fix it?

Ref: microG #455
@devemux86 devemux86 added the bug label Dec 25, 2017
@devemux86 devemux86 added this to the 0.10.0 milestone Dec 25, 2017
@devemux86
Copy link
Collaborator

Thanks for the report!

Indeed after tests it fixes LwHttp issues.
@ale5000-git do you want to post a pull request with the change?

@devemux86 devemux86 mentioned this issue Dec 25, 2017
Closed
@devemux86 devemux86 changed the title Incorrect HTTP headers LwHttp incorrect HTTP headers Dec 25, 2017
@ale5000-git
Copy link
Author

Done: #461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.9.1
Development

No branches or pull requests
2 participants
@devemux86 @ale5000-git