Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TagFix Challenge always returns "Oops, your changes could not be saved" #2344

Closed
wielandb opened this issue May 22, 2024 · 5 comments · Fixed by maproulette/maproulette-backend#1121
Assignees
Labels
bug Something isn't working

Comments

@wielandb
Copy link

wielandb commented May 22, 2024

Describe the bug
I have tried to create multiple challenges using the new cooperative "TagFix" type challenge. I generate the GeoJSON using python, and I can upload it and the tasks are built without problems.

However, when trying to commit a change in such a MapRoulette Challenge, it always returns the error "Oops, your changes could not be saved".

What is the problem? And even more important: How do I as challenge owner can get feedback about what's wrong with my challenge?

Expected behavior
When "yes" is clicked, the OSM object is updated with the proposed tags.

To Reproduce

  • Put this in a GeoJSON file:
�{"type": "FeatureCollection", "features": [{"type": "Feature", "geometry": {"type": "Point", "coordinates": [13.4495432, 48.567051]}, "properties": {"@id": "relation/272138", "latitude": 48.567051, "longitude": 13.4495432}}], "cooperativeWork": {"meta": {"version": 2, "type": 1}, "operations": [{"operationType": "modifyElement", "data": {"id": "relation/272138", "operations": [{"operation": "setTags", "data": {"name": "Wörthstraße"}}]}}]}}
  • Create a challenge with it
    • Try to click "yes" on the proposed edit
  • See error

Desktop (please complete the following information):

  • OS: any
  • Browser any
@CollinBeczak
Copy link
Collaborator

CollinBeczak commented May 23, 2024

You were running into this error:
{
"status": "KO",
"message": "https://www.openstreetmap.org/api/0.6/changeset/xxxxxxxxxxx/upload failed with status code 412 (Precondition failed: Way 272138 must have at least one node)"
}
The relation you were trying to submit was being wrapped in a way wrapper instead of a relation wrapper. Thank you for making a ticket about this! I will have a hot fix for this soon.

The fix: maproulette/maproulette-backend#1121

@wielandb
Copy link
Author

Thank you very much for the fix!

@wielandb
Copy link
Author

Unsure if this is of interest to improve UX, but on our end, we did not get the "Way 272138 must have at least one node" part of the error, just everything before. We could deduce that it had something to do with the relation not beeing handled correctly by the 412 error, but maybe it would be an idea to relay the error reason to the user to improve future debugging.

@wielandb
Copy link
Author

Question: When will this fix be in production? So that we can check if this resolved our issue.

@CollinBeczak
Copy link
Collaborator

There are a lot of other changes that will be included in the deployment including the fix for your issue. So, I'm going to wait to deploy until tonight when MapRoulette is less active, and the fix should be up in production tomorrow morning if there are no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants