Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.fetch_resources does not correctly combine creation and opening options #315

Closed
goergen95 opened this issue Jul 29, 2024 · 0 comments · Fixed by #316
Closed

.fetch_resources does not correctly combine creation and opening options #315

goergen95 opened this issue Jul 29, 2024 · 0 comments · Fixed by #316
Assignees
@goergen95
Labels
bug Something isn't working

Comments

@goergen95
Copy link
Member

In case either of one is NULL, the resulting options currently is set to NULL.

mapme.biodiversity/R/get_resources.R

Line 156 in dc0c924

opts = unlist(x[["co"]], x[["oo"]]),

It should be set to

unlist(c(x[["co"]], x[["oo"]]))
@goergen95 goergen95 self-assigned this Jul 29, 2024
@goergen95 goergen95 added the bug Something isn't working label Jul 29, 2024
@goergen95 goergen95 linked a pull request Jul 29, 2024 that will close this issue
fixes creation and opening options combination #316
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goergen95 goergen95

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes creation and opening options combination mapme-initiative/mapme.biodiversity
1 participant
@goergen95