Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.check_portfolio overwrites assetid if present #305

Closed
goergen95 opened this issue Jul 9, 2024 · 0 comments · Fixed by #306
Closed

.check_portfolio overwrites assetid if present #305

goergen95 opened this issue Jul 9, 2024 · 0 comments · Fixed by #306
Assignees

Comments

@goergen95
Copy link
Member

The value of assetid is currently overwritten if it is present:

if ("assetid" %in% names(x) && verbose) {
msg <- paste("Found a column named 'assetid'.",
"Overwritting its values with a unique identifier.",
sep = " "
)
message(msg)
}
x[["assetid"]] <- 1:nrow(x)

However, to support advanced use cases (e.g. batching and chunking), it would be better if we check for uniqueness of its value and only overwrite if assets are not uniquely identified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant