Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting the android docker build #622

Closed
wipfli opened this issue Dec 20, 2022 · 4 comments · Fixed by #712
Closed

Documenting the android docker build #622

wipfli opened this issue Dec 20, 2022 · 4 comments · Fixed by #712
Assignees
Labels

Comments

@wipfli
Copy link
Contributor

wipfli commented Dec 20, 2022

We have docker containers for building the Android package but I am not sure that we have documentation on how to update and generate the docker containers.

The containers are stored in the github container registry at the MapLibre org level at https://github.com/orgs/maplibre/packages

We have:

  • android-ndk-r21b
  • android-base

Linux builder is probably for Qt, right @ntadej?

Let's document how we can update the docker images for the android builds...

@wipfli
Copy link
Contributor Author

wipfli commented Dec 20, 2022

@wipfli
Copy link
Contributor Author

wipfli commented Dec 20, 2022

To close this issue, I think we should document how to update the docker stuff in platform/android/README.md

@wipfli
Copy link
Contributor Author

wipfli commented Dec 20, 2022

We have github actions workflows to generate the docker images and upload them to the container registry.

The workflow has a manual trigger:

https://github.com/maplibre/maplibre-gl-native/blob/d11df0066e258cf798594448fcb3eb784bf8e348/.github/workflows/android-docker-ndk-r21b.yml#L1-L3

And it uses the CR_PAT GitHub secret, which I think stands for "container registry personal access token":

https://github.com/maplibre/maplibre-gl-native/blob/d11df0066e258cf798594448fcb3eb784bf8e348/.github/workflows/android-docker-ndk-r21b.yml#L19-L21

But I don't know if this access token still works. Only the people from the MapLibre Governing Board and I have write access at the moment to the maplibre github org level at the moment.

@louwers
Copy link
Collaborator

louwers commented Jan 17, 2023

Helpful advice from @wipfli: do an Android release once this ticket has been completed to ensure that it (still) goes smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
2 participants