Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-Mapbox sources are billed in v1.x #1507

Closed
hyperknot opened this issue Aug 16, 2022 · 1 comment
Closed

non-Mapbox sources are billed in v1.x #1507

hyperknot opened this issue Aug 16, 2022 · 1 comment
Labels
invalid This doesn't seem right

Comments

@hyperknot
Copy link

hyperknot commented Aug 16, 2022

I've just figured out a bug in Mapbox GL JS which is also present in Maplibre 1.0. I'm copying it below.
mapbox/mapbox-gl-js#12171


Steps to Trigger Behavior

Load a non-Mapbox source with Mapbox access token specified in v1.x.
The load will be billed by Mapbox.

Detail

The bug is a missing bracket on the 2nd line here:
https://github.com/mapbox/mapbox-gl-js/blob/50adf1cc14e5aef09099f15c5cb803eaa5f72a48/src/util/mapbox.js#L392-L397

This means everyone who used 1.x with an access token was billed for non-Mapbox source loads.

Simple bug - probably thousands of dollars billed in error to customers.

Note: using Prettier would have made it obvious to see this bug.

@HarelM
Copy link
Collaborator

HarelM commented Aug 21, 2022

We can't change this file as it will violate Mapbox terms and conditions.
Only Mapbox can change it.
You are welcome to use version 2.x of this library which doesn't communicate with Mapbox at all.
Sorry...

@HarelM HarelM closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2022
@HarelM HarelM added the invalid This doesn't seem right label Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants