-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optionally hit worker even if some sources didn't hold data for the tile #75
Comments
👍 makes sense, let's add an option. |
I like this proposal, but might counter with something slightly more fine-grained:
The Thoughts? |
bump. any further thoughts here? I'm fine with having 3 modes per @morganherlocker's
|
I'm fine with the API proposed above too. |
👋 Any update on this? I'd love to see this feature supported as well. |
Hello from the future! I am running into this today and would also love to have this feature. I'm hacking in a workaround for now, but excited for #110. |
Per this code:
the worker bails out and returns a reduce event if any source doesn't have data for the requested tile. This is usually great, but in some cases where you want to compare disparate data sources and are relying on reduce events to send back information about how much data each source does or doesn't exist in a tile, you end up losing information.
For example, if I want to find the length of roads in San Francisco that are matched by GPS datapoints. I would like to keep a tally of the total length of road in the bbox, as well as how much is matchable by GPS points. Right now, if there is no GPS data in the tile, we bail out, so I'm missing some of the total length information.
To maintain compatibility and provide optimization for the usual cases where you want this bail-out behavior, I'm proposing we add a tile-reduce option for this, maybe
requireAllSources: false
(defaulted true).cc @morganherlocker @aaronlidman @mourner
The text was updated successfully, but these errors were encountered: