Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster geometry collections #5

Closed
1ec5 opened this issue Jan 16, 2017 · 2 comments
Closed

Cluster geometry collections #5

1ec5 opened this issue Jan 16, 2017 · 2 comments
Labels
enhancement

Comments

@1ec5
Copy link

1ec5 commented Jan 16, 2017 •
edited
Loading

Supercluster’s constructor requires a GeoJSONFeatures (aka feature collection). However, it should be possible to cluster geometry collections as well.

One complication is that getTile() currently synthesizes a feature with cluster and point_count properties for each cluster, whereas a geometry collection contains only geometries.

/ref mapbox/mapbox-gl-native#7622
/cc @mourner @jfirebaugh
@1ec5 1ec5 mentioned this issue Jan 16, 2017
Closed
jfirebaugh referenced this issue in mapbox/mapbox-gl-native Jan 16, 2017
@1ec5
[core] Avoid clustering unclusterable GeoJSON
84f9069 
Ignore empty feature collections or non–feature collections for the purposes of clustering or tiling. A source’s clustering option can only be set when the source is constructed, but setGeoJSON() enables the developer to swap a clusterable feature for an unclusterable geometry and back.
@mourner
Copy link
Member

mourner commented Jan 16, 2017

I don't think we should support this — it's a weird use case that will makes the code and documentation more confusing.

@mourner mourner closed this as completed Jan 16, 2017
@mourner mourner reopened this Jan 16, 2017
@mourner
Copy link
Member

mourner commented Jul 10, 2018

Closing for now.

@mourner mourner closed this as completed Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mourner @1ec5