You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, OS X is building with -fvisibility-inlines-hidden. I hit an issue where the internal use of a mason RapidJSON package in GeoJSONVT was causing linker warnings when the "host" library was directly using mason RapidJSON as well. Given that -fvisibility=hidden only matters for shared libraries, and all mason packages should be linked statically by consumers, could we set -fvisibility=hidden globally?
In light of mapbox/mapbox-gl-native#2584 (comment) and the need to manually expose symbols in mapbox/geojson-vt-cpp#15, we should probably not set this on all packages by default, instead only opting in for packages where we know the public API symbols are explicitly exposed, or where we can make such a change.
Currently, OS X is building with
-fvisibility-inlines-hidden
. I hit an issue where the internal use of a mason RapidJSON package in GeoJSONVT was causing linker warnings when the "host" library was directly using mason RapidJSON as well. Given that-fvisibility=hidden
only matters for shared libraries, and all mason packages should be linked statically by consumers, could we set-fvisibility=hidden
globally?Refs mapbox/mapbox-gl-native#2584
/cc @jfirebaugh
The text was updated successfully, but these errors were encountered: