Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always build with -fvisibility=hidden? #120

Closed
mikemorris opened this issue Oct 27, 2015 · 1 comment
Closed

Always build with -fvisibility=hidden? #120

mikemorris opened this issue Oct 27, 2015 · 1 comment

Comments

@mikemorris
Copy link
Contributor

Currently, OS X is building with -fvisibility-inlines-hidden. I hit an issue where the internal use of a mason RapidJSON package in GeoJSONVT was causing linker warnings when the "host" library was directly using mason RapidJSON as well. Given that -fvisibility=hidden only matters for shared libraries, and all mason packages should be linked statically by consumers, could we set -fvisibility=hidden globally?

Refs mapbox/mapbox-gl-native#2584

/cc @jfirebaugh

@mikemorris
Copy link
Contributor Author

In light of mapbox/mapbox-gl-native#2584 (comment) and the need to manually expose symbols in mapbox/geojson-vt-cpp#15, we should probably not set this on all packages by default, instead only opting in for packages where we know the public API symbols are explicitly exposed, or where we can make such a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant