This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Make AssetRequest overridable by platform implementations #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs #579: Android can now rename AssetRequest to FileRequest and implement it differently
kkaefer
added a commit
that referenced
this pull request
Dec 17, 2014
Make FileRequest overridable by platform implementations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android (#579), we can now rename AssetRequest to FileRequest and implement it differently: Instead of loading from the file system, we're loading from a the zip file the application ships in to avoid decompressing everything on app startup.
We should probably rename
file://toasset://and disallow access to outside the install path of the app.