Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] fixes #4536 include podspec for static framework #5653

Merged
merged 3 commits into from
Jul 14, 2016
Merged

[ios] fixes #4536 include podspec for static framework #5653

merged 3 commits into from
Jul 14, 2016

Conversation

frederoni
Copy link
Contributor

Fixes #4536

@frederoni frederoni added iOS Mapbox Maps SDK for iOS build labels Jul 12, 2016
@frederoni frederoni added this to the ios-v3.3.1 milestone Jul 12, 2016
@frederoni frederoni force-pushed the 4536-fixup-include-static-podspec branch from ab5c75f to f83e5e7 Compare July 12, 2016 13:16
@frederoni frederoni force-pushed the 4536-fixup-include-static-podspec branch from f83e5e7 to b2e16c2 Compare July 12, 2016 13:18
@frederoni frederoni added the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Jul 12, 2016
1ec5
1ec5 reviewed Jul 12, 2016
View reviewed changes
platform/ios/Mapbox-iOS-SDK-static-part.podspec
m.libraries = 'c++', 'sqlite3', 'z'
m.pod_target_xcconfig = {
'OTHER_CPLUSPLUSFLAGS' => '-std=gnu++11 -stdlib=libc++',
'OTHER_LDFLAGS' => '-ObjC',
Copy link
Contributor

@1ec5 1ec5 Jul 12, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is still needed, given #4641. If you omit this flag and include an MGLMapView in a storyboard without ever importing the Mapbox module in code, does the map view render at runtime, or do you get a console warning about an unrecognized class?

@frederoni
Copy link
Contributor Author

frederoni commented Jul 12, 2016 •
edited
Loading

To clarify the process:

Dynamic

  1. Mapbox-iOS-SDK.podspec or Mapbox-iOS-SDK-symbols.podspec gets copied to the dynamic build folder.
  2. m.source :http 'url_to_release.zip' => :path '.'
  3. m.vendored_frameworks dynamic/Mapbox.framework => Mapbox.framework
  4. LICENSE.md gets copied to the dynamic build folder.

Static

  1. The content of Mapbox-iOS-SDK.podspec or Mapbox-iOS-SDK-symbols.podspec until the deployment_target line gets copied to the static build folder.
  2. Mapbox-iOS-SDK-static-part.podspec gets appended to the file in step 1.
  3. m.source :http 'url_to_release.zip' => :path '.'
  4. LICENSE.md gets copied to static build folder.

@frederoni frederoni force-pushed the 4536-fixup-include-static-podspec branch from 10ef630 to c8b9510 Compare July 13, 2016 10:06
@boundsj
Copy link
Contributor

boundsj commented Jul 13, 2016

👍 thanks for writing the clarification

@frederoni frederoni removed the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Jul 14, 2016
@frederoni frederoni merged commit c531686 into release-ios-v3.3.0 Jul 14, 2016
@frederoni frederoni deleted the 4536-fixup-include-static-podspec branch July 14, 2016 09:30
@friedbunny friedbunny mentioned this pull request Aug 31, 2016
Merged
1ec5 added a commit that referenced this pull request Jan 10, 2017
@1ec5
[macos] Generate local podspecs
af29273 
Ported from #5653.
@1ec5 1ec5 mentioned this pull request Jan 10, 2017
Merged
6 tasks
1ec5 added a commit that referenced this pull request Jan 13, 2017
@1ec5
[macos] Added CocoaPods podspecs
7ca4020 
Ported from #5653.
1ec5 added a commit that referenced this pull request Jan 15, 2017
@1ec5
[macos] Added CocoaPods podspecs
483d1aa 
Ported from #5653.
1ec5 added a commit that referenced this pull request Jan 15, 2017
@1ec5
[macos] Added CocoaPods podspecs
23db3c6 
Ported from #5653.
1ec5 added a commit that referenced this pull request Jan 15, 2017
@1ec5
[macos] Upgrade macOS deployment and distribution (#7649)
4adcdac 
* [macos] Updated deployment scripts

Ported fixes from #6581 and #6740.

* [macos] Acknowledge AppleScript support

* [macos] Prepared for published documentation

Also added link to Dash docset.

* [macos] Added CocoaPods podspecs

Ported from #5653.

* [macos] Rewrote readme; updated screenshot

* [macos] Include setup instructions in standalone docs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@frederoni frederoni

Labels
build iOS Mapbox Maps SDK for iOS
Projects
None yet
Milestone
ios-v3.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@frederoni @boundsj @1ec5