[ios] fixes #5127, #5128, #5130 added enabled and selected property to MGLAnnotationView #5297
Conversation
| @@ -41,6 +41,19 @@ NS_ASSUME_NONNULL_BEGIN | |||
| @property (nonatomic, assign, getter=isFlat) BOOL flat; | |||
|
|
|||
| /** | |||
| This property defaults to NO and becomes YES when the view is tapped/clicked on. | |||
There was a problem hiding this comment.
Nit: Let’s remove the word “clicked”; that term is only appropriate for OS X, and this file isn’t shared with the OS X SDK.
There was a problem hiding this comment.
As with the MKAnnotationView.selected property, the documentation for this property should mention that you shouldn’t set it directly.
|
That should cover it. Let me know if there's anything else @1ec5 |
| @@ -41,10 +41,17 @@ NS_ASSUME_NONNULL_BEGIN | |||
| @property (nonatomic, assign, getter=isFlat) BOOL flat; | |||
|
|
|||
| /** | |||
| This property defaults to NO and becomes YES when the view is tapped/clicked on. | |||
| This property should not be changed directly. | |||
There was a problem hiding this comment.
Thanks, this line should actually be at the end of the comment, rather than the beginning. The first several words of a documentation comment appear in the code completion popup, so it should be descriptive and reasonably unique.
Though it’s intended for Swift and Markdown instead of Objective-C and HeaderDoc, this Swift API design guideline document has a great guideline on forming documentation comments (scroll up and click “Expand all details now” to see it).
|
This looks great, other than the one comment about comments. |
8f2c430 to
968afc3
Compare
968afc3 to
1e75237
Compare
|
👍 |
Fixes #5127 #5128 #5130
Added
selectedandenabledproperty toMGLAnnotationViewand hooked it up.Added
mapView:did(De)SelectAnnotationView:protocol methods.@boundsj
I kept the annotation and annotation views selection protocol methods separated but let me know if you want me to combine them into
mapView:did(De)SelectAnnotation:annotationView:/cc @1ec5 @friedbunny