This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Fill the initial changeTimes with the reference timestamp of the first frame
#5175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the first frame On the Javascript implementation the array is automatically filled with zeroes which is not the same thing as `TimePoint::min()`. Here we need to get our own "zero" which is the timestamp of the first frame. Fixes #5109
|
Tested on Android and confirmed it worked. I'm going to merge this into |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Javascript implementation the array is automatically filled with
zeroes which is not the same thing as
TimePoint::min(). Here we needto get our own "zero" which is the timestamp of the first frame.
Fixes #5109