This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
3697 compass insets #4219
Closed
3697 compass insets #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 7, 2016 11:20
… button to follow the contentInset (which is using the top and bottom layout guides by default).
|
@boundsj Any progress on this one? Will it make the ios-v3.3.0 release? |
|
@postmechanical the changelog for 3.3.0 is already very large and we want to focus on getting what is already in that release shipped as soon as possible. We can land this PR in a followup patch release. |
| toItem:nil | ||
| attribute:NSLayoutAttributeNotAnAttribute | ||
| multiplier:1 | ||
| constant:_compassView.image.size.height]; |
There was a problem hiding this comment.
These constraints never gets added to a view and there's no other reference to them so ARC will have them removed immediately. They're also unnecessary since the UIImageView is initialized with -initWithImage which will handle the size in -intrinsicContentSize IIRC. This also means that line: 374 _compassView.frame = CGRectMake(... is redundant and can be removed.
|
Closing this in favour of #5671 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating position of compass, logo and attribution button according to the contentInsets.
The contentInsets by default is already defined by the top and bottom layout guides, so this PL simplifies the code.
Less constraints update is also better for speed. Compass size does not need to be updated each time.