This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Avoid calling AnnotationManager::updateStyle until the style is loaded #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8de752d to
d30e16c
Compare
|
Let's try it, with plans to pull it back out of release if it's problematic. But agree. I'll merge now. |
d30e16c to
50a33e4
Compare
|
Cherry-picked to Thanks for opening this against the release branch @jfirebaugh — I've been cherry-picking in both directions as a result of us not consistently doing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3037
cc @incanus -- I stuck this on the 3.0.0 milestone / branch. It should be fairly safe but I'd be fine with waiting too.