Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Force Bitcode in make ipackage #2903

Merged
merged 1 commit into from
Nov 3, 2015
Merged

Force Bitcode in make ipackage #2903

merged 1 commit into from
Nov 3, 2015

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Nov 2, 2015

make ipackage now performs a Bitcode-enabled archive build for devices, making it possible to archive a Bitcode-enabled application that links against the Mapbox iOS SDK.

@incanus, can you verify that the resulting static library contains all the expected symbols? I did notice some additional missing symbol warnings in the CreateUniversalBinary step, such as the one below, but I think those are the same things we try to suppress when calling libtool with the -no_warning_for_no_symbols flag:

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: for architecture: x86_64 file: /Users/mxn/hub/mapbox-gl-native/build/mbgl.build/Release-iphonesimulator/core.build/Objects-normal/x86_64/libmbgl-core.a(camera.o) has no symbols

/ref #2332
/cc @mikemorris

@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS build labels Nov 2, 2015
@1ec5 1ec5 self-assigned this Nov 2, 2015
@1ec5 1ec5 added this to the ios-v3.0.0 milestone Nov 2, 2015
@mikemorris
Copy link
Contributor

These are the same warnings I'm seeing in Xcode when building a CocoaPods project with libMapbox.a copied over from #2584 (comment)

@incanus
Copy link
Contributor

incanus commented Nov 3, 2015

Looking good here.

@incanus
Copy link
Contributor

incanus commented Nov 3, 2015

Merging ahead of Travis running here, since this only affects the iOS package script and we don't build iOS on Travis.

`make ipackage` now performs a Bitcode-enabled archive build for devices.
@incanus incanus force-pushed the 1ec5-archive-bitcode branch from bfa9b3b to dda99fb Compare November 3, 2015 00:10
@incanus incanus merged commit dda99fb into master Nov 3, 2015
@incanus incanus deleted the 1ec5-archive-bitcode branch November 3, 2015 00:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants