This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make ipackage
now performs a Bitcode-enabled archive build for devices, making it possible to archive a Bitcode-enabled application that links against the Mapbox iOS SDK.@incanus, can you verify that the resulting static library contains all the expected symbols? I did notice some additional missing symbol warnings in the
CreateUniversalBinary
step, such as the one below, but I think those are the same things we try to suppress when callinglibtool
with the-no_warning_for_no_symbols
flag:/ref #2332
/cc @mikemorris