This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Only print Sprites not found messages after the sprites are loaded and parsed #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @picciano |
If we don't set Sprites at all or the Sprites were not loaded yet, the warnings can be misleading.
b26b144 to
3835155
Compare
|
The |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sprites are loaded asynchronously and if we get the tiles before the sprites, we are going to see a lot of "Sprites not found" messages, which can be misleading. We should only print these messages after the sprite define on the Style is loaded.