[ios, build] Add MORE_SIMULATORS option to iOS make commands

[friedbunny]

Adds a MORE_SIMULATORS option to our make ios-test commands that enables more device types and iOS versions.

Example usage: make ios-test MORE_SIMULATORS=YES

Notes

• This is useful only locally or on actual Mac hardware and doesn’t address [ios] Run test suite against more versions of iOS on CI #10708 — cloud CI providers like CircleCI do not provide the resources necessary to execute parallel simulators in a reliable or performant way.
• If you run this now, there are many failing tests. This is a starting point — we must go through the test failures and fix them.
• Use the new make ios-install-simulators command to install the necessary simulators. This uses xcversion.
• Bumps our default test simulator device from iPhone 6 to iPhone 8. Xcode 11 and iOS 13 will drop support for iPhone 6, while the iPhone 8 is currently one of the most widely-used iOS devices in the wild.

/cc @mapbox/maps-ios

[julianrex]

Love this! Can we add an XR to the mix please - it's the phone seeing the greatest uptake currently.

[friedbunny]

Note that this is what I get when running make ios-test MORE_SIMULATORS=1 with Xcode 10:

Failing tests:
	test:
		-[MGLOfflineStorageTests testAddFileContent]
		-[MGLOfflineStorageTests testAddFileContent]
		-[MGLOfflineStorageTests testAddFileContent]
		-[MGLOfflineStorageTests testAddFileContent]
		-[MGLOfflineStorageTests testAddFileContent]
		-[MGLOfflineStorageTests testAddFileContent]
		-[MGLOfflineStorageTests testAddFileContent]
		-[MGLOfflineStorageTests testAddFileContent]
		-[MGLOfflineStorageTests testAddFileContent]
		-[MGLOfflineStorageTests testAddFileContent]
		-[MGLOfflineStorageTests testAddFileContent]
		-[MGLOfflineStorageTests testAddFileContent]
		-[MGLOfflineStorageTests testAddFileContent]

Seems like this test is taking a very long time:

Test case '-[MGLOfflineStorageTests testAddFileContent]' failed on 'iPhone Xs Max' (12.384 seconds)
Test case '-[MGLOfflineStorageTests testAddFileContent]' failed on 'iPhone Xʀ' (12.567 seconds)
Test case '-[MGLOfflineStorageTests testAddFileContent]' failed on 'iPad Pro (11-inch)' (11.952 seconds)

... so there’s something about this test that isn’t compatible with multiple concurrent simulators.

Ticketed at #14928.

/cc @fabian-guerra

[friedbunny]

Can we add an XR to the mix please - it's the phone seeing the greatest uptake currently.

Done.

Incidentally, my methodology in picking devices was to represent most size-classes (iPhone and iPad) and screen density variants (@2x and @3x) for supported iOS versions.

[julianrex]

If you run this now, there are many failing tests

I just did 😮😢

[friedbunny]

There are a few failures I’ve seen:

• Make sure your simulators are set to en_US, otherwise you’ll hit [darwin] Some unit tests are locale-dependent #14908.
• Some older simulators don’t seem to want to boot — maybe try reinstalling them, but cause is unknown. Xcode 11 will drop iOS 8 & 9 simulator support, so this will eventually be solved for us.
• [ios, build] Add MORE_SIMULATORS option to iOS make commands #14903 (comment) was fixed in [ios] Simplify -[MGLOfflineStorageTests testAddFileContent] #14948.

@julianrex if you see any other failures, please be sure to ticket them out.

[julianrex]

Some older simulators don’t seem to want to boot

I think I had this - possibly the Xcode 11 beta installing a newer CoreSimulator framework? Regardless, I deleted the framework and restarted Xcode 10, and life seems better.