This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fixes for static analyzer warnings #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed analyzer warnings in http-nsurl target, which is MRR rather than ARC.
These values weren’t being used for anything.
While tracking the user’s location, a double tap not near the user dot now turns off location tracking instead of bouncing between the tapped location and the user location.
|
Hat tip goes to @kkaefer for remembering to run the static analyzer. I only followed its instructions. 😄 |
|
Upstream bugs filed upstream: memononen/libtess2#19 and angusj/polyclipping#134. |
1ec5
added a commit
that referenced
this pull request
May 6, 2015
Fixes for static analyzer warnings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various warnings flagged by Xcode’s static analyzer. Mostly these changes fix leaks, but there is one user-visible change, which is that double-tapping while tracking user location no longer bounces around. See individual commit messages for details.
/cc @kkaefer @bleege