Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Crash MapBox on selecting multiple annotations. #9066

Closed
evgzor opened this issue May 22, 2017 · 4 comments
Closed

Crash MapBox on selecting multiple annotations. #9066

evgzor opened this issue May 22, 2017 · 4 comments
Labels
annotations Annotations on iOS and macOS or markers on Android crash iOS Mapbox Maps SDK for iOS
Milestone

Comments

@evgzor
Copy link

evgzor commented May 22, 2017

Platform: iOS
Mapbox SDK version: 3.5.4

Steps to trigger behavior

  1. Load map with multiple annotations
  2. call asynchronous remove and add Annotation in race conditions
  3. Observe the result

Expected behavior

No crash delegate method was called susesfully

Actual behavior

Crash with:
screenshot 2017-05-22 11 10 04
As was mention in #8163
if disable all removeAnnotations functions the crash does not happend anymore.

@Guardiola31337 Guardiola31337 added annotations Annotations on iOS and macOS or markers on Android crash iOS Mapbox Maps SDK for iOS labels May 22, 2017
@fabian-guerra fabian-guerra added this to the ios-v3.6.0 milestone May 22, 2017
@boundsj
Copy link
Contributor

boundsj commented May 24, 2017

Hi @evgzor. The problem you are describing sounds a lot like the issue caused by #8754. That was fixed by #9025 and that fix was just published in https://github.com/mapbox/mapbox-gl-native/releases/tag/ios-v3.6.0-beta.1.

Can you please test using ios-v3.6.0-beta.1 and see if it fixes the issue you see?

I'm going to close this issue now but please reopen it if you can reproduce with that latest beta. If you do reopen this, please attach an actual crash report / trace file instead of the assembly view screenshot from Xcode. Also, if you have a gist or sample project that can reproduce the issue please feel free to attach it.

@boundsj boundsj closed this as completed May 24, 2017
@evgzor
Copy link
Author

evgzor commented May 24, 2017

Hi @boundsj it's true that current issue is not reproducible anymore on https://github.com/mapbox/mapbox-gl-native/releases/tag/ios-v3.6.0-beta.1. But I got another crash on 3.6.0-beta1 version: #9096. Also, u changed API and now for draggable annotation in swift it requires implementing "init(annotation: MGLAnnotation?, reuseIdentifier: String?)" which is a bit strange.

@boundsj
Copy link
Contributor

boundsj commented May 25, 2017

Also, u changed API and now for draggable annotation in swift it requires implementing "init(annotation: MGLAnnotation?, reuseIdentifier: String?)" which is a bit strange.

Thanks for noting this issue! It is fixed by #9104 on the release-ios-v3.6.0-android-v5.1.0 branch and the fix will be in the next pre-release of v3.6.0.

@evgzor
Copy link
Author

evgzor commented May 25, 2017

For the people who still in use 3.5 version u may temporarily fix it by
self.view(for: annotation)?.frame = CGRect(x: 0, y: 0, width: 0, height: 0)
self.removeAnnotation(annotation)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
annotations Annotations on iOS and macOS or markers on Android crash iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

4 participants