Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Move cameraBy* methods from MGLMapView to MGLMapCamera #7990

Open
fabian-guerra opened this issue Feb 8, 2017 · 3 comments
Open

Move cameraBy* methods from MGLMapView to MGLMapCamera #7990

fabian-guerra opened this issue Feb 8, 2017 · 3 comments
Assignees
@fabian-guerra
Labels
gl-ios iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor

Comments

@fabian-guerra
Copy link
Contributor

MGLMapView contains several camera related methods, to keep things a bit more modular, this methods should be moved to their own MGLMapCamera_Private.h file:

cameraByPanningWithTranslation:panGesture
cameraByZoomingToZoomLevel: aroundAnchorPoint:
cameraByRotatingToDirection:aroundAnchorPoint:
cameraByTiltingToPitch:
@fabian-guerra fabian-guerra added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Feb 8, 2017
@fabian-guerra fabian-guerra self-assigned this Feb 8, 2017
@1ec5
Copy link
Contributor

1ec5 commented Feb 9, 2017

This refactoring was originally proposed in #5584 (comment).

@stale stale bot added the archived Archived because of inactivity label Nov 15, 2018
@stale
Copy link

stale bot commented Nov 24, 2018

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Nov 24, 2018
@friedbunny friedbunny reopened this Nov 26, 2018
@stale stale bot removed the archived Archived because of inactivity label Nov 26, 2018
@stale stale bot added the archived Archived because of inactivity label May 25, 2019
@stale
Copy link

stale bot commented May 26, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed May 26, 2019
@fabian-guerra fabian-guerra reopened this May 28, 2019
@stale stale bot removed the archived Archived because of inactivity label May 28, 2019
@jmkiley jmkiley added the gl-ios label Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fabian-guerra fabian-guerra

Labels
gl-ios iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@boundsj @friedbunny @1ec5 @fabian-guerra @jmkiley