Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Use LZFSE for payload compression #4888

Closed
kkaefer opened this issue Apr 28, 2016 · 5 comments
Closed

Use LZFSE for payload compression #4888

kkaefer opened this issue Apr 28, 2016 · 5 comments
Labels
archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS performance Speed, stability, CPU usage, memory usage, or power usage

Comments

@kkaefer
Copy link
Member

kkaefer commented Apr 28, 2016

Given that we can't use the original compressed response (#3886) on iOS, we should use Apple's LZFSE algorithm introduced in iOS 9 and OS X 10.11.

@kkaefer kkaefer added the performance Speed, stability, CPU usage, memory usage, or power usage label Apr 28, 2016
@jfirebaugh
Copy link
Contributor

Use it where? For resources stored in the database? I don't think we should make the database storage platform-specific -- people want to be able to transfer offline caches between devices, which potentially includes transfers between iOS and Android devices.

@Motti-Shneor
Copy link

As of yesterday, Apple open-sourced lzfse! I don't yet know where to find the sources... but I heard the announcement.

@kkaefer
Copy link
Member Author

kkaefer commented Jun 21, 2016

It's open source: https://github.com/lzfse/lzfse

@kkaefer
Copy link
Member Author

kkaefer commented May 30, 2017

people want to be able to transfer offline caches between devices, which potentially includes transfers between iOS and Android devices.

I haven't encountered this use case so far; the only transfer I've seen is from a pre-built database (on desktop) to phones. Adding support for LZFSE would only take effect for new items stored in the cache, and we'd still be able to decompress gzip-compressed responses.

@kkaefer kkaefer added Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS labels May 30, 2017
@stale stale bot added the archived Archived because of inactivity label Nov 6, 2018
@stale
Copy link

stale bot commented Nov 29, 2018

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Nov 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS performance Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

No branches or pull requests

3 participants