Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Rotation isn't persisted #463

Closed
kkaefer opened this issue Sep 8, 2014 · 5 comments
Closed

Rotation isn't persisted #463

kkaefer opened this issue Sep 8, 2014 · 5 comments
Labels

Comments

@kkaefer
Copy link
Member

kkaefer commented Sep 8, 2014

When rotating the map, then panning, the rotation jumps back to 0.

@kkaefer kkaefer added the bug label Sep 8, 2014
@kkaefer kkaefer changed the title Rotation isn't persistet Rotation isn't persisted Sep 8, 2014
@incanus
Copy link
Contributor

incanus commented Nov 19, 2014

Which OS(es)? Still valid?

@ljbade
Copy link
Contributor

ljbade commented Nov 19, 2014

Just discovered Android-mason has this bug. Working on it.

@ljbade
Copy link
Contributor

ljbade commented Nov 19, 2014

Fixed Android in dca5f8b

@ljbade
Copy link
Contributor

ljbade commented Nov 19, 2014

@incanus Found the main problem.

When restoring the map's state, you must set the zoom level before you set the zoom level.

The reason is that the zoom defaults to zoomed out, so due to disabling rotation when zoomed out, it ignores the rotation setting.

E.g.
Bad:

  • setBearing
  • setZoom

Good:

  • setZoom
  • setBearing

Can you check that iOS, OSX, and Linux load the map state in the correct order?

This will also cause bugs in end user apps by developers who do not understand this limitation. Easiest way to fix is to just remove rotation restriction on zoom level. Otherwise we should document this in map.hpp, iOS/OSX framework, and Android Java docs.

@incanus
Copy link
Contributor

incanus commented Nov 19, 2014

Can you check that iOS, OSX, and Linux load the map state in the correct order?

Yep, will check this out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants