This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
MapContext::update should not reset updateFlags wholesale #3082
Labels
Core
The cross-platform C++ core, aka mbgl
Comments
jfirebaugh
added a commit
that referenced
this issue
Nov 20, 2015
The previous fix resulted in annotations sometimes never being added. This would happen if, during the execution of MapContext::update where Update::Annotations was set, the style itself was loaded but some of its subresources (sprite or sources) were not. #3082 is a follow up issue to make MapContext::update less error-prone.
jfirebaugh
added a commit
that referenced
this issue
Nov 20, 2015
The previous fix resulted in annotations sometimes never being added. This would happen if, during the execution of MapContext::update where Update::Annotations was set, the style itself was loaded but some of its subresources (sprite or sources) were not. #3082 is a follow up issue to make MapContext::update less error-prone.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This leads to fragile updates -- if some precondition needed by the update (like the style being loaded) is not met, then the flag gets reset and lost unless there is also code at the point where the precondition becomes met that reinstates the flag.
Instead, we should check and reset flags on an individual basis.
The text was updated successfully, but these errors were encountered: