Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Discrepancy in values between gl-js and native for localIdeographFontFamily #14866

Closed
tristen opened this issue Jun 6, 2019 · 4 comments · Fixed by #14862
Closed

Discrepancy in values between gl-js and native for localIdeographFontFamily #14866

tristen opened this issue Jun 6, 2019 · 4 comments · Fixed by #14862
Labels
Core The cross-platform C++ core, aka mbgl feature GL JS parity For feature parity with Mapbox GL JS text rendering
Milestone
release-picklejuice

Comments

@tristen
Copy link
Member

tristen commented Jun 6, 2019 •
edited
Loading

I'm using a custom ideograph for iOS but attempting to define it the same way as gl-js:

localIdeographFontFamily: "'Hiragino Sans', 'Noto Sans CJK SC', 'sans-serif'"

In iOS at least, you can only set a single font as the ideographic font. Which is different from what's supported in GL-JS where fallbacks can be used.

This seems confusing and I would expect the value provided to behave the same way.
@julianrex
Copy link
Contributor

/cc @m-stephen @1ec5 @friedbunny

@julianrex julianrex added the iOS Mapbox Maps SDK for iOS label Jun 6, 2019
@friedbunny friedbunny added feature GL JS parity For feature parity with Mapbox GL JS Core The cross-platform C++ core, aka mbgl text rendering and removed iOS Mapbox Maps SDK for iOS labels Jun 6, 2019
@1ec5
Copy link
Contributor

1ec5 commented Jun 6, 2019

On iOS/macOS, we could allow the Info.plist key to be set to an array instead of a string. But there will need to be some changes in the Objective-C implementation in mbgl to specify a font cascade list as part of the font description.

@chloekraw
Copy link
Contributor

Related, possible workaround: #9308

@chloekraw
Copy link
Contributor

@tristen this will be closed by #14862

@m-stephen m-stephen mentioned this issue Jun 27, 2019
Merged
@friedbunny friedbunny added this to the release-p milestone Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Core The cross-platform C++ core, aka mbgl feature GL JS parity For feature parity with Mapbox GL JS text rendering
Projects
None yet
Milestone
release-picklejuice
Development

Successfully merging a pull request may close this issue.

[ios, macos] Default to local rendering of CJK characters, using system font mapbox/mapbox-gl-native
5 participants
@tristen @friedbunny @1ec5 @julianrex @chloekraw