Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Port 'Collator' string comparison support to native #11692

Closed
ChrisLoer opened this issue Apr 16, 2018 · 2 comments
Closed

Port 'Collator' string comparison support to native #11692

ChrisLoer opened this issue Apr 16, 2018 · 2 comments
Assignees
Labels
Android Mapbox Maps SDK for Android feature GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS localization Human language support and internationalization Qt Mapbox Maps SDK for Qt, aka Qt Location Mapbox GL

Comments

@ChrisLoer
Copy link
Contributor

Port of mapbox/mapbox-gl-js#6270, see also design discussion at mapbox/mapbox-gl-js#4136.

Unfortunately this isn't a trivial port because we'll depend on platform-specific behavior. The rough plan is to implement this is to use built-in string comparison support on iOS and Android, and to bundle ICU (along with the necessary resource bundle) for other platforms. I suspect we won't figure out what we're actually going to do with Qt until the rubber hits the road.

/cc @anandthakker @nickidlugash @1ec5 @brunoabinader

@ChrisLoer ChrisLoer self-assigned this Apr 16, 2018
@ChrisLoer ChrisLoer added feature GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS Android Mapbox Maps SDK for Android Qt Mapbox Maps SDK for Qt, aka Qt Location Mapbox GL localization Human language support and internationalization labels Apr 16, 2018
@brunoabinader
Copy link
Member

For Qt, we should probably follow the same procedure as adopted for other platforms using ICU as backend.

@tobrun
Copy link
Member

tobrun commented Jul 6, 2018

This landed, follow up tickets #12268 and #12269 for Android/iOS

@tobrun tobrun closed this as completed Jul 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android feature GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS localization Human language support and internationalization Qt Mapbox Maps SDK for Qt, aka Qt Location Mapbox GL
Projects
None yet
Development

No branches or pull requests

3 participants