From 11d3eff173b5a596b8f0683a93658cbd4ca1eb95 Mon Sep 17 00:00:00 2001 From: Antonio Zugaldia Date: Fri, 26 Feb 2016 10:05:20 -0500 Subject: [PATCH] [android] Remove invoke to DeleteGlobalRef to avoid client crash See #4121 --- platform/android/src/jni.cpp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/platform/android/src/jni.cpp b/platform/android/src/jni.cpp index cfb7ca34e3c..9855529c665 100755 --- a/platform/android/src/jni.cpp +++ b/platform/android/src/jni.cpp @@ -1940,8 +1940,7 @@ void JNICALL setOfflineRegionObserver(JNIEnv *env, jobject obj, jobject offlineR env2->SetBooleanField(jstatus, offlineRegionStatusRequiredResourceCountIsPreciseId, status.requiredResourceCountIsPrecise); env2->CallVoidMethod(observerCallback, offlineRegionObserveronStatusChangedId, jstatus); - // Delete global refs and detach when we're done - env2->DeleteGlobalRef(observerCallback); + // Detach when we're done detach_jni_thread(theJVM, &env2, renderDetach); } @@ -1976,8 +1975,7 @@ void JNICALL setOfflineRegionObserver(JNIEnv *env, jobject obj, jobject offlineR env2->SetObjectField(jerror, offlineRegionErrorMessageId, std_string_to_jstring(env2, error.message)); env2->CallVoidMethod(observerCallback, offlineRegionObserveronErrorId, jerror); - // Delete global refs and detach when we're done - env2->DeleteGlobalRef(observerCallback); + // Detach when we're done detach_jni_thread(theJVM, &env2, renderDetach); } @@ -1989,8 +1987,7 @@ void JNICALL setOfflineRegionObserver(JNIEnv *env, jobject obj, jobject offlineR // Send limit env2->CallVoidMethod(observerCallback, offlineRegionObserveronLimitId, limit); - // Delete global refs and detach when we're done - env2->DeleteGlobalRef(observerCallback); + // Detach when we're done detach_jni_thread(theJVM, &env2, renderDetach); }