Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon collision boxes don't account for icon-text-fit #5641

Closed
ChrisLoer opened this issue Nov 9, 2017 · 1 comment
Closed

Icon collision boxes don't account for icon-text-fit #5641

ChrisLoer opened this issue Nov 9, 2017 · 1 comment
Labels

Comments

@ChrisLoer
Copy link
Contributor

See discussion at #5632.

CollisionFeature takes a Shaping as an input for determining the size of collision boxes. This works fine for text, but for icons with icon-text-fit: true, the quads generated for the icon by getIconQuads may not match the Shaping.

I suspect the right fix here is to move most of the icon-text-fit logic into shapeIcon.

My guess is this hasn't been a big deal in practice because when people are using icon-text-fit they also use icon-allow-overlap and icon-ignore-placement, and rely on the matching text's collision box. But it'd be better not to have that gotcha.

/cc @jfirebaugh @ansis @anandthakker

@kkaefer
Copy link
Member

kkaefer commented Sep 16, 2019

This will be fixed by #8741

@kkaefer kkaefer closed this as completed Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants