Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests for and refactor camera.js #1773

Closed
lucaswoj opened this issue Dec 1, 2015 · 2 comments
Closed

Improve tests for and refactor camera.js #1773

lucaswoj opened this issue Dec 1, 2015 · 2 comments
Labels
workflow 💅

Comments

@lucaswoj
Copy link
Contributor

lucaswoj commented Dec 1, 2015

There seems to be a lot of duplicated code in js/ui/camera.js. Simplifying the module would help prevent bugs like #1744 #1429 and make the module easier to test.

For example, rotateTo could just be a call to easeTo. More ambitiously, easeTo could probably be a parameterized call to flyTo.

ref #1771
@1ec5 1ec5 mentioned this issue Dec 21, 2015
Merged
@lucaswoj lucaswoj mentioned this issue Jan 19, 2016
Closed
@lucaswoj
Copy link
Contributor Author

closing as a subset of #1992, feel free to re-open

@mourner
Copy link
Member

mourner commented Mar 10, 2016

I think this refactoring was covered recently by @ansis, don't remember the exact PR.

@mourner mourner closed this as completed Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
workflow 💅
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mourner @lucaswoj