Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate sprite jsons into stylesheet #1083

Closed
peterqliu opened this issue Mar 12, 2015 · 2 comments
Closed

Integrate sprite jsons into stylesheet #1083

peterqliu opened this issue Mar 12, 2015 · 2 comments

Comments

@peterqliu
Copy link
Contributor

Is there a compelling reason we keep sprite.json and sprite@2x.json as separate files from the stylesheet, rather than as JSON objects within?

It adds more (unnecessary?) moving parts, and introduces the potential for missing links

@incanus
Copy link
Contributor

incanus commented Mar 12, 2015

Broader discussion happening over in mapbox/mapbox-gl-style-spec#220.

The reason we have sprites is similar to the web (less resources to handle) but also optimizing texture loads in GL since you can bind one image, then use the offsets to map textures.

Since we also will eventually support runtime addition and subtraction of sprites, I'd say JSON's days are numbered.

@jfirebaugh
Copy link
Contributor

Yeah let's keep the discussion over on the style-spec issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants