Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ScanManga] Connector not working #2291

Closed
SaladFiinger opened this issue Sep 14, 2020 · 9 comments · Fixed by #2799
Closed

[ScanManga] Connector not working #2291

SaladFiinger opened this issue Sep 14, 2020 · 9 comments · Fixed by #2799
Labels
Website Change Problem or Feature for existing Website

Comments

@SaladFiinger
Copy link

Did you read the troubleshooting guide
Yes

Is the website of the connector working properly / are you able to see the manga within your browser
Yes

Describe the bug
When i synchronize the local list, i have the error " Failed to update manga list for ScanManga. Unexpected end of JSON input."

Screenshots
image

HakuNeko (please complete the following information):

  • Version [e.g. 6.17]
@SaladFiinger SaladFiinger added the Website Change Problem or Feature for existing Website label Sep 14, 2020
@ronny1982 ronny1982 removed the Website Change Problem or Feature for existing Website label Sep 15, 2020
@ronny1982
Copy link
Contributor

ronny1982 commented Sep 15, 2020

Cannot be reproduced on my end.
Make sure the manga list (website) is working in your browser (using same proxy/VPN connection as in HakuNeko in case of region block).

@SaladFiinger
Copy link
Author

The website works correctly in my browser and i don't use any proxy or vpn.

@Sheepux
Copy link
Contributor

Sheepux commented Sep 15, 2020

Able to reproduce, getting HTTP 200 on json, but json is empty ( https://www.scan-manga.com/scanlation/scan.data.json )

@ronny1982
Copy link
Contributor

ronny1982 commented Sep 15, 2020

Thats because the google ad header and the XMLHTTPRequest header are missing.
HakuNeko provides both of them when making the request.

@Sheepux
Copy link
Contributor

Sheepux commented Sep 15, 2020

Yeah but i meant, empty from within hakuneko :D

@ronny1982
Copy link
Contributor

ronny1982 commented Sep 15, 2020

HakuNeko uses a random User Agent, maybe some of them are blocked...

image

image

@Sheepux
Copy link
Contributor

Sheepux commented Sep 15, 2020

Request seems the same. Agent or IP related? (i guess that we are both french with saladFiinger )
http_request.zip
Going to investigate this week to see if i'm able to find something.

@Sheepux Sheepux added the Website Change Problem or Feature for existing Website label Sep 16, 2020
@fcaylus
Copy link
Contributor

fcaylus commented Dec 21, 2020

Hi !
I may have found the issue (I am a French user too). The JSON file is empty when accept-language is set to fr (which is the default when you have a French machine), but has content for any other language.

That would explain why it was working for @ronny1982 but not for @SaladFiinger and @Sheepux.

However, I don't have any explanation on the reason behind it.

I'll link a PR to this issue.

PS: That's an amazing project @ronny1982

@ronny1982
Copy link
Contributor

I have to admit, i would never have expected such weird logic... thats ScanManga for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Website Change Problem or Feature for existing Website
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants