Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateRangePicker format is not adjust accordingly automatically when timepicker is enabled #83

Closed
Aamish26622 opened this issue May 19, 2024 · 4 comments

Comments

@Aamish26622
Copy link

When enabling timepicker, the $data did not included the time values nor the time was displayed on frontend unless we manually call displayFormat() and set the format accordingly.

Ideally, when one used timepicker() function on the DateRangePicker, it should automatically format it according (unless they have manully called displayFormat()).

@Aamish26622
Copy link
Author

Aamish26622 commented May 19, 2024

Fixed in PR #82

now you can simply call timepicker() and the relavant function to automatically adjust the format without calling displayFormat

@Aamish26622
Copy link
Author

@majidalzariey any thoughts ?

@malzariey
Copy link
Owner

@Aamish26622 Thank you for your great PR, but I would prefer to resolve if any issue is available in the format with the getFormat() and getDisplayFormat rather than implementing alot of new variables.

Might as well introduce a new API to enforce the format as it is.

@malzariey
Copy link
Owner

Fixed in beta version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants