Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoundingRegion: Tolerance argument in the methods #20

Open
francocipollone opened this issue May 4, 2022 · 0 comments
Open

BoundingRegion: Tolerance argument in the methods #20

francocipollone opened this issue May 4, 2022 · 0 comments

Comments

@francocipollone
Copy link
Collaborator

Context

Comes from this PR comment.

BoundingRegion api doesn't know about tolerance. In the first implementation that we have, BoundingBox asks for tolerance in its constructor.

Question is, would it be better to request tolerance only in the methods? This will imply recognizing from the BoundingRegion's api that tolerance is requested when calling the methods.

Probably the most related use-case is that this package in general, maliput will be used and when objects are being constructed there won't be possible to call maliput::api::RoadGeometry::linear_tolerance() in order to match tolerances, as probably the RoadNetwork won't be ready to be queried yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant