Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MailjetTransport.php optimation #16

Open
kevinveenbirkenbach opened this issue Apr 10, 2018 · 4 comments
Open

MailjetTransport.php optimation #16

kevinveenbirkenbach opened this issue Apr 10, 2018 · 4 comments

Comments

@kevinveenbirkenbach
Copy link

There are the following issues in the file MailjetTransport.php:

PHPDocs are wrong:

  • some @parameters are not declared
  • some @throws are not declared
  • some @returns contain not all possible return types
  • some @var use relative paths which can not be mapped by some IDE's e.g. (PHPStorm)

Logic:

  • There is some logic which is unnecessary in the function bulkSend

Variables:

  • $resultStatus is never used
  • $sendCount is double declared
@kevinveenbirkenbach kevinveenbirkenbach mentioned this issue Apr 10, 2018
Open
@kevinveenbirkenbach
Copy link
Author

Please merge pull request #17 ;)

@kevinveenbirkenbach
Copy link
Author

It would be really nice if I could get some kind of feedback ;)

@Nightbr
Copy link
Member

Nightbr commented Apr 17, 2018

ping @mailjet/dev-evangelist ?

@kachar
Copy link

kachar commented Apr 19, 2018

Hey! I've added some ideas for improvement as we're on the optimisation topic. Please check the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kachar @Nightbr @kevinveenbirkenbach