Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

void function magit-log-propertize-keywords #736

Closed
ns-rse opened this issue Jan 6, 2025 · 2 comments
Closed

void function magit-log-propertize-keywords #736

ns-rse opened this issue Jan 6, 2025 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@ns-rse
Copy link

ns-rse commented Jan 6, 2025

Thanks for the amazing work on Magit/Forge/Transient and all the other Emacs packages @tarsius far and away one of the most useful packages out there. 👍

Observed and expected behaviour

In a magit buffer if I try to expand the >Issues section it normally expands and shows synched issues. Recently though it resulted in Symbol's function definition is void: magit-log-propertize-keywords.

Debugger entered--Lisp error: (void-function magit-log-propertize-keywords)
  magit-log-propertize-keywords(nil #("Consolidate pages" 0 37 (face (nil forge-issue-open) font-lock-face (nil forge-issue-open))))
  forge--format-topic-title(#<forge-issue forge-issue-1715901aba44>)
  forge--format-topic-line(#<forge-issue forge-issue-1715901aba44> 2)
  forge--insert-topic(#<forge-issue forge-issue-1715901aba44> 2)
  #f(compiled-function () #<bytecode 0x138f5b63ed1cc57e>)()
  #f(compiled-function () #<bytecode -0x595ffd8b4178f5a>)()
  magit-section--maybe-wash(#<magit-section "Issues" [issues status] 874-[885-]885>)
  magit-section-show(#<magit-section "Issues" [issues status] 874-[885-]885>)
  magit-section-toggle(#<magit-section "Issues" [issues status] 874-[885-]885>)
  funcall-interactively(magit-section-toggle #<magit-section "Issues" [issues status] 874-[885-]885>)
  call-interactively(magit-section-toggle nil nil)
  command-execute(magit-section-toggle)

Similar behaviour is seen if I try to view a specific topic with N v i and the debug shows...

Debugger entered--Lisp error: (void-function magit-log-propertize-keywords)
  apply(debug (error (void-function magit-log-propertize-keywords)))
  transient--exit-and-debug(error (void-function magit-log-propertize-keywords))
  magit-log-propertize-keywords(nil #("Consolidate Linux and GNU/Linux pages" 0 37 (face (nil forge-issue-open) font-lock-face (nil forge-issue-open))))
  forge--format-topic-title(#<forge-issue forge-issue-171590581f3a>)
  forge--format-topic-line(#<forge-issue forge-issue-171590581f3a>)
  #f(compiled-function (topic) #<bytecode 0x17dd28f2eb7779c2>)(#<forge-issue forge-issue-171590581f3a>)
  mapcar(#f(compiled-function (topic) #<bytecode 0x17dd28f2eb7779c2>) (#<forge-issue forge-issue-171590581f3a> #<forge-issue forge-issue-171590567158> #<forge-issue forge-issue-171590209b98> #<forge-issue forge-issue-17159075790c> #<forge-issue forge-issue-171590759810> #<forge-issue forge-issue-17159075a048> #<forge-issue forge-issue-17159075a87c>))
  forge--topic-collection((#<forge-issue forge-issue-171590581f3a> #<forge-issue forge-issue-171590567158> #<forge-issue forge-issue-171590209b98> #<forge-issue forge-issue-17159075790c> #<forge-issue forge-issue-171590759810> #<forge-issue forge-issue-17159075a048> #<forge-issue forge-issue-17159075a87c>))
  forge--read-topic("View issue" forge-current-issue #<forge--topics-spec forge--topics-spec-17158fe34f9e> #<forge--topics-spec forge--topics-spec-17158f63e7f2>)
  forge-read-issue("View issue")
  byte-code("\300\301!C\207" [forge-read-issue "View issue"] 2)
  eval((byte-code "\300\301!C\207" [forge-read-issue "View issue"] 2))
  advice-eval-interactive-spec((byte-code "\300\301!C\207" [forge-read-issue "View issue"] 2))
  #f(compiled-function (spec) #<bytecode -0x36c22d0173ee871>)((byte-code "\300\301!C\207" [forge-read-issue "View issue"] 2))
  funcall(#f(compiled-function (spec) #<bytecode -0x36c22d0173ee871>) (byte-code "\300\301!C\207" [forge-read-issue "View issue"] 2))
  call-interactively(forge-visit-issue nil nil)
  command-execute(forge-visit-issue)

I noticed this was calling some byte-copmiled files so removed all .elc files from both magit and forge directories and byte compiled them anew.

M-x magit-version RET

Magit 20250105.2145 [>= 20250105.2145], Transient 20250103.1731, Forge 20250101.1813, Git 2.47.1, Emacs 29.4, gnu/linux
@tarsius tarsius added the duplicate This issue or pull request already exists label Jan 6, 2025
@tarsius
Copy link
Member

tarsius commented Jan 6, 2025

#735

@tarsius tarsius closed this as completed Jan 6, 2025
@ns-rse
Copy link
Author

ns-rse commented Jan 6, 2025

👍 sorry for the duplication, did search was probably posted whilst I was writing. Thanks for fixing it so quickly 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants