Is it possible to approve a pull request from within forge?

[BigTheta]

I have checked the manual, FAQ and reddit, I don't see anywhere where its even been asked before.

I was asked to review a pull request, I was able to view the commits and comment on the PR. Now, I would like to approve the PR. I know gh has this functionality. It seems like the sort of functionality forge was intended to support?

[tarsius]

Not yet, I believe. Supporting it isn't a top priority but eventually it will probably be implemented. (The projects I am involved in for the most part work by merging or not merging pull-requests without explicitly and beforehand approve or reject it.)

[tarsius]

Is it possible to join/approve a pull request from within forge?

I just remembered that I implemented this quite recently in 3112ade. It's available from the merge menu, but not by default so...

[tarsius]

Certain transient popups hide some of their suffix commands by default. These additional suffixes can be enabled interactively. TL;DR Enter the transient as usual and type C-x l.

_{This is a canned response; it may not apply 100% in this case.}

[tarsius]

I have checked the manual,

I've just added it to the manual.

[BigTheta]

Thank you. Much appreciated.

[BigTheta]

Sorry, I never actually attempted this until just now.

I just remembered that I implemented this quite recently in [3112ade]

To be clear, you are taking about merging (not approving?) I don't see anything in that commit regarding approving reviews.

It's available from the merge menu, but not by default so...

I'm looking at the merge menu with suffixes enabled and I still don't see anything regarding approving the topic?

[tarsius]

To be clear, you are taking about merging (not approving?)

Yeah. Your use of the word "join" confused me. That sounded like a synonym for "merge".

So no. Approving still isn't supported and adding support is a low priority.

[aiguofer]

Check out https://github.com/wandersoncferreira/code-review (I just found it looking for better ways to do reviews using forge)

Slightly weird switching between forge and code-review, but they do integrate fairly well.

[magandrez]

@BigTheta If you are still interested on this, you can check out https://github.com/charignon/github-review

[tarsius]

I actually implemented that last week but wanted to look into #313 before pushing anything. Trying to implement #313 unfortunately put me into a refactor frenzy, so I had to abandon that, to refocus on other more straight forward parts of the backlog.

The new commands on /A and /R in forge-topic-menu (<C-return>) let you write a message (which is optional you can just leave the buffer empty), but that's it. There's no support for commenting on specific parts of the pull-request. #75 is the issue about that.

[vunhan]

Could we have this feature support for Gitlab too?

[tarsius]

Could we have this feature support for Gitlab too?

I plan to start focusing on GitLab in about two months. Until then I intend to focus on other parts of the backlog, even when it means that GitLab support falls behind some more.

A big ticket when it comes to improved GitLab support is to switch to their GraphQL API, for those features (mostly queries but not mutations) that already use GraphQL in the GitHub backend.

Many features that are currently missing in the GitLab backend would require some REST now, and I avoid doing that because I would soon have to redo that work using GraphQL.