From 319233fad86c3e284535604fedcf70742ae0c1f4 Mon Sep 17 00:00:00 2001 From: Alexander Menk Date: Tue, 18 Sep 2012 16:30:29 +0200 Subject: [PATCH] Throw exception if joinAttribute is used A exception is better than a silent fail: Silent fails can cause very business critical problems that go unnoticed. --- app/code/core/Mage/Sales/Model/Resource/Collection/Abstract.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/core/Mage/Sales/Model/Resource/Collection/Abstract.php b/app/code/core/Mage/Sales/Model/Resource/Collection/Abstract.php index 4f2495f80c73f..f8f176d28016c 100755 --- a/app/code/core/Mage/Sales/Model/Resource/Collection/Abstract.php +++ b/app/code/core/Mage/Sales/Model/Resource/Collection/Abstract.php @@ -161,6 +161,6 @@ public function getAllIds($limit = null, $offset = null) */ public function joinAttribute($alias, $attribute, $bind, $filter = null, $joinType = 'inner', $storeId = null) { - return $this; + throw new Exception('Not implemented.'); } }