Magento import product csv do not import all crosssell relations

[oleksandrmakhno]

Preconditions

1. Magento EE 2.3.5-p2, Magento CE 2.4
2. Mysql version 5.7.31-0ubuntu0.18.04.1
3. Php version 7.3.21-1+ubuntu18.04.1+deb.sury.org+1

Steps to reproduce

1. Prepare for import file product.csv with data in column crosssell_skus
2. Product.csv file should contain more than 100 products
3. the product A on line 100 or lower should have crosssell_sku, let say 5 relations
4. the product B on line 101 or higher should have crosssell_sku, obligatory less then 5 relations (less relations than in product A)

Expected result

1. product A crosssell_sku relations will be imported to Magento
2. product B crosssell_sku relations will be imported to Magento

Actual result

1. product A crosssell_sku relations will be imported to Magento
2. product B crosssell_sku relations won't be imported to Magento

Workaround

1. import product in csv up to 100 products (rows) each, so if more - need to split csv

Research results

1. we have column catalog_product_link.link_id which is autoincrement
2. for some reason we managing this autoincrement value in the code
3. on line Tax & decimal rounding method #1240 we get $nextLinkId = 1 (in my tests it was always 1)
4. on line shipping address & billing address missing in print order #1255 we are in loop of bunches (100 products each), but $nextLinkId is always 1
5. as result of every bunch autoincrement starting from 1 - new lines are not inserted in catalog_product_link
6. as possible solution see added line Restrict to store or website #1254, in such case $nextLinkId will be updated every bunch with actual value
7. I presume the bunch logic was added later, while $nextLinkId logic was not refactored

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [+] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @oleksandrmakhno. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[engcom-Oscar]

Hi @oleksandrmakhno !

Thank you for your report and collaboration!

I closing this issue, because I was unable to reproduce it using provided Steps to Reproduce from the Description section on clean 2.4-develop branch of Magento. Perhaps the issue has been already fixed in the scope of other tasks.

But if you still run into this problem please update or provide additional information/steps/preconditions in the Description section and reopen this issue.