Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order Notification not sending to Admin in Multistores #19520

Closed
ankurverma5540 opened this issue Dec 3, 2018 · 9 comments
Closed

Order Notification not sending to Admin in Multistores #19520

ankurverma5540 opened this issue Dec 3, 2018 · 9 comments
Labels
Component: Email Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@ankurverma5540
Copy link

ankurverma5540 commented Dec 3, 2018

Preconditions (*)

  1. Crate Two Store views and Stores
  2. Place an order from any stores. user will get order notification email but admin will not get any email

Steps to reproduce (*)

  1. Crate Two Store views and Stores
    2.Place an order from any stores. user will get order notification email but admin will get any email

Expected result (*)

  1. We an order is placed, user and admin should receive email.

Actual result (*)

  1. Only User receive email but admin not getting any email.
@magento-engcom-team
Copy link
Contributor

Hi @ankurverma5540. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@ankurverma5540 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Dec 3, 2018
@ankurverma5540
Copy link
Author

yes

@ghost ghost self-assigned this Dec 3, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Dec 3, 2018

Hi @engcom-backlog-andrii. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Dec 3, 2018
@gwharton
Copy link
Contributor

gwharton commented Dec 3, 2018

Looks like a duplicate of #16203

@ankurverma5540
Copy link
Author

There is no solution in that thread

@gwharton
Copy link
Contributor

gwharton commented Dec 3, 2018

The fix is there, Its just you haven't applied it correctly.

If you have no /lib/internal/Magento folder, then it will be /vendor/magento instead.

Don't copy the entire file, just locate the files that have changed, then make the necessary changes inside the files in accordance with the commit. Make sure you clean/build DI/Redeploy static content.

And yes, we are editing the core!

@gwharton gwharton closed this as completed Dec 3, 2018
@ankurverma5540
Copy link
Author

according to this commit
9a7c9e5#diff-dfb3ee5a7f863458afea75f5524cd2e5

Change in app/code/Magento/Newsletter/Test/Unit/Model/Queue/TransportBuilderTest.php
Magento/Framework/Mail/Template/TransportBuilder.php
and in this file
Magento/Framework/Mail/Test/Unit/Template/TransportBuilderTest.php

??

@ghost ghost added the Component: Email label Dec 3, 2018
@gwharton
Copy link
Contributor

gwharton commented Dec 3, 2018

Those paths are for github installs, for composer installs the paths would be

/vendor/magento/newsletter/Test/Unit/Model/Queue/TransportBuilderTest.php
/vendor/magento/framework/Mail/Template/TransportBuilder.php
/vendor/magento/framework/Mail/Test/Unit/Template/TransportBuilderTest.php

@ankurverma5540
Copy link
Author

ankurverma5540 commented Dec 3, 2018

If i made changes to
/vendor/magento/newsletter/Test/Unit/Model/Queue/TransportBuilderTest.php
then, email not coming to admin but also admin login not working.

@ghost ghost removed their assignment Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Email Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

3 participants