Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.2.4 - Condition Category Chooser Crashes Page if Store has Several Nested Categories #15121

Closed
rjtulloh opened this issue May 9, 2018 · 7 comments
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@rjtulloh
Copy link

rjtulloh commented May 9, 2018

Preconditions

  1. Magento CE 2.2.4 PHP 7.1.17 and PHP 7.0.30
  2. Create a set of categories such that a category with no subcategories is followed by two categories that do have one subcategory. Issue can also be observed in environment with sample data freshly deployed.

Steps to reproduce

  1. Create a new Cart Price Rule from Marketing -> Cart Price Rules.
  2. Scroll to "Actions" section and open it.
  3. Under "Apply the rule only to cart items matching the following conditions (leave blank for all items)." section, add a new condition
  4. For the condition attribute, select "Category."
  5. Click on the ellipses, then open the Category Chooser.

Expected result

  1. List of categories should appear to select from.

Actual result

  1. No categories appear and the page becomes unresponsive and eventually crashes.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 9, 2018
@stkristobal
Copy link

stkristobal commented May 12, 2018

I get the same. @rjtulloh are you also getting limits to attribute filters? Ours stops after 'Category':
sceenshot

@hostep
Copy link
Contributor

hostep commented May 16, 2018

@rjtulloh & @stkristobal: it looks like there is a new PR which fixes this issue: #15265

@stkristobal
Copy link

@hostep worked for me - thanks for the heads up!

@jonshipman
Copy link

Just a note, with my build I needed to apply the fix to buildHashChildren in the next method.

Here is my alternative fix
6e57b65

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label May 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rjtulloh. Thank you for your report.
The issue has been fixed in #15265 by @keithbentrup in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.5 release.

@sidolov
Copy link
Contributor

sidolov commented Sep 4, 2018

Hi @rjtulloh. Thank you for your report.
The issue has been fixed in #17816 by @nmalevanec in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@Vladekarpa
Copy link

Hi is this problem fixed for older version of magento, i have 2.1 and i have the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

7 participants