Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabeling js merge,bundle,minify does not work in admin #10605

Closed
Taral-Patoliya opened this issue Aug 21, 2017 · 37 comments
Closed

Disabeling js merge,bundle,minify does not work in admin #10605

Taral-Patoliya opened this issue Aug 21, 2017 · 37 comments
Assignees
Labels
Area: Admin UI Component: Developer Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: needs update Additional information is require, waiting for response Issue: On Hold Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@Taral-Patoliya
Copy link

Taral-Patoliya commented Aug 21, 2017

When disabling the js, and css ,merge, minify and bundling for default scope and keeping them enabled for website and store view scope, the admin still loads minified and bundled js

Preconditions

  1. Magento Version : 2.1.3

Steps to reproduce

  1. Disable js merge, minify, bundling for default scope in system config
  2. Enable the same in Website scope
  3. Enable the same in store view scope

Expected result

  1. Admin should load all the js files separately
  2. Frontend should load bundled files

Actual result

1.Admin loads all the files bundled

@hostep
Copy link
Contributor

hostep commented Aug 21, 2017

This is a duplicate of #6638 (which was unfortunately closed due to Magento support people not understanding the problem :p).
It's certainly a bug, but a very low priority one in my opinion.

@Taral-Patoliya: any particular reasons for wanting this behaviour? Just out of curiousity :) We no longer need this ourselves, as it was a workaround for an unrelated issue which we were having, but which was fixed later on.

@Taral-Patoliya
Copy link
Author

Taral-Patoliya commented Aug 22, 2017

@hostep We need to disable this behavior because we are getting js errors while accessing tiny_mce in backend for CMS Pages and Blocks, the tiny mce does not work with the js merged and bundled.

Please have a look at below screenshot
screenshot from 2017-08-22 18 59 19

@okorshenko
Copy link
Contributor

okorshenko commented Sep 7, 2017

@Taral-Patoliya thank you for your report.
Please use the issue reporting guidelines to report an issue. Include the preconditions, the steps required to reproduce, the actual result, and the expected result.
Please, add the following information:

  • Preconditions: Magento version

@Taral-Patoliya
Copy link
Author

@okorshenko I have updated the issue, and added the precondition

@magento-engcom-team magento-engcom-team added bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed and removed G1 Passed labels Sep 11, 2017
@okorshenko okorshenko added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 14, 2017
@roma-glushko
Copy link
Member

I'll work on this one. Just to let you know. Thanks.

@roma-glushko
Copy link
Member

I would like to leave an update here.
I have investigated this issue and create PR #11270 to fix it.

Looking forward to your review.

Thanks.

@hostep
Copy link
Contributor

hostep commented Oct 7, 2017

Nice job @roma-glushko!

But since in Magento 2.2.0, the developer tab is no longer available in production mode, should effort still be put into fixing this bug? Unless you can still manipulate these settings from the config.php file? (which I haven't verified yet)

@versdivers
Copy link

This is still an issue in Magento 2.2.4 and therefor the editors are not working like @Taral-Patoliya explained

@engcom-Dash engcom-Dash self-assigned this Nov 3, 2022
@m2-assistant
Copy link

m2-assistant bot commented Nov 3, 2022

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Dash
Copy link
Contributor

@magento give me 2.4-develop branch

@engcom-Dash
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Dash
Copy link
Contributor

Hi @ Taral-Patoliya,

We are worked the issue with 2.4-develop instance...we are not able to reproduce the issue.we are getting actual result.
Steps we followed:

1.Install magento Instance
2.go to stores
3.Click Advanced Go to developer
4.Click Js settings
5.Disable Js merge, minify, bundling for default scope in system config
6.Enable the same in Website scope
7.Enable the same in store view scope
8.In admin Panel all the Js files loaded separately

We are getting expected result as per your description.

I attached the screenshots for your Clarification:
These Screenshots refer Stores configuration as per your steps to reproduce.
Screenshot 2022-11-03 at 3 28 01 PM
Screenshot 2022-11-03 at 3 28 19 PM

Screenshot 2022-11-03 at 2 46 59 PM

Once the configuration admin Loaded all the Js files loaded separately....
Screenshot 2022-11-03 at 3 29 40 PM
Screenshot 2022-11-03 at 3 31 50 PM

Let us know if we missing anything !!!

Thanks!!!

@engcom-Dash engcom-Dash added Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: needs update Additional information is require, waiting for response labels Nov 3, 2022
@hostep
Copy link
Contributor

hostep commented Nov 3, 2022

@engcom-Dash: it kind of looks good I think (not sure why files aren't bundled in the admin that sounds like a problem still).
But next to this test, can you also try the reverse by:

  • Disabling Js merge, minify, bundling for default scope in system config
  • Enabling them in Website scope
  • Enabling them in store view scope

Which you said you did, but according to your screenshots you did the exact opposite...

Update: make sure you have production mode enabled, otherwise those settings won't be put into effect

@denysaw-gaming
Copy link

How to unsubscribe of this channel? Magento is finally dead, but I'm still getting notifications of this thread and GitHub bugs to unsubscribe me ((

@hostep
Copy link
Contributor

hostep commented Nov 3, 2022

@denysaw-gaming: There should be an Unsubscribe button on the right side of this ticket. If there is only a Subscribe button, press it and then press Unsubscribe afterwards, that should hopefully do the trick :)
Or stop watching the project entirely in github, that might also help ...

If you want to see what the future of Magento looks like, I would suggest you start following https://mage-os.org/ instead where we will try to continue with moving it forward without Adobe's help.

@denysaw
Copy link

denysaw commented Nov 3, 2022

@hostep Thanx ;) I got I was logged in with different account. And Github was unable to unsubscribe me cuzz of that.

@engcom-Bravo engcom-Bravo self-assigned this Dec 1, 2022
@m2-assistant
Copy link

m2-assistant bot commented Dec 1, 2022

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo removed their assignment Dec 1, 2022
@engcom-Dash
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Dash
Copy link
Contributor

Hi @hostep ,

Thanks for contribution with us,

1.We verified the issue according to your last comment...we are not able to reproduce the issue and we are trying to reproduce the issue in 2.4-develop branch.
2.As per your instructions we trying to reproduce the issue reversed by
reverse by:

Disabling Js merge, minify, bundling for default scope in system config
Enabling them in Website scope
Enabling them in store view scope

Magento version-2.4-develop
PHP 8.1

Steps we followed:
1.Install magento Instance
2.go to stores
3.Click Advanced Go to developer
4.Click Js settings
5.Enable Js merge, minify, bundling for default scope in system config
6.Disable the same in Website scope
7.Disable the same in store view scope

We are getting error in console and Js file or bundled files not loaded in both admin panel and store view.

Screenshots for your reference:
Screenshot 2023-01-11 at 7 29 56 AM
Screenshot 2023-01-11 at 7 30 20 AM
Screenshot 2023-01-11 at 7 30 33 AM
Screenshot 2023-01-11 at 7 41 14 AM
Screenshot 2023-01-11 at 7 41 18 AM

Let us know if we are missing anything!!!

Thanks!!!

@engcom-Dash
Copy link
Contributor

Hi @Taral-Patoliya ,

We have noticed that this issue has not been updated for a period of 14 Days.
Hence we assume that this issue is fixed now, so we are closing it. Please raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Admin UI Component: Developer Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: needs update Additional information is require, waiting for response Issue: On Hold Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Development

No branches or pull requests