Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply review suggestion to the media modules #1725

Closed
sivaschenko opened this issue Aug 5, 2020 · 1 comment · Fixed by magento/magento2#29396
Closed

Apply review suggestion to the media modules #1725

sivaschenko opened this issue Aug 5, 2020 · 1 comment · Fixed by magento/magento2#29396
Assignees
@sivaschenko
Labels
Priority: P1 Needs to be fixed before any other issues Progress: done Severity: S2 Affects non-critical data or functionality and forces users to employ a workaround
Milestone
2.1.0

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Aug 5, 2020 •
edited
Loading

  • Remove Magento\MediaContentSynchronizationApi\Api\SynchronizerInterface
  • Remove try-catch block from \Magento\MediaGalleryMetadata\Model\File\ExtractMetadata::extractMetadata
  • Remove GetContentHashInterface
  • Remove DI configuration of Magento\MediaGalleryUi\Ui\Component\Listing\Filters\Options\UsedIn
@m2-assistant
Copy link

m2-assistant bot commented Aug 5, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@sivaschenko sivaschenko self-assigned this Aug 5, 2020
@sivaschenko sivaschenko mentioned this issue Aug 5, 2020
Merged
4 tasks
@sivaschenko sivaschenko added Priority: P1 Needs to be fixed before any other issues Severity: S2 Affects non-critical data or functionality and forces users to employ a workaround labels Aug 5, 2020
@lenaorobei lenaorobei added this to the 2.1.0 milestone Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sivaschenko sivaschenko

Labels
Priority: P1 Needs to be fixed before any other issues Progress: done Severity: S2 Affects non-critical data or functionality and forces users to employ a workaround
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Apply review suggestion to the media modules
2 participants
@sivaschenko @lenaorobei