From ea54825bdf9406d0e77897f39de82d3689c60afd Mon Sep 17 00:00:00 2001 From: yorke Date: Thu, 21 Mar 2019 08:50:05 +0800 Subject: [PATCH] [portsorch] Fix inconsistent return value in bindAclTable (#791) Signed-off-by: yorke --- orchagent/portsorch.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/orchagent/portsorch.cpp b/orchagent/portsorch.cpp index 26209412071f..e8bf1eacdc1b 100644 --- a/orchagent/portsorch.cpp +++ b/orchagent/portsorch.cpp @@ -826,7 +826,7 @@ bool PortsOrch::createBindAclTableGroup(sai_object_id_t id, sai_object_id_t &gro { SWSS_LOG_ERROR("Failed to bind port %s to ACL table group %lx, rv:%d", port.m_alias.c_str(), group_oid, status); - return status; + return false; } break; } @@ -842,7 +842,7 @@ bool PortsOrch::createBindAclTableGroup(sai_object_id_t id, sai_object_id_t &gro { SWSS_LOG_ERROR("Failed to bind LAG %s to ACL table group %lx, rv:%d", port.m_alias.c_str(), group_oid, status); - return status; + return false; } break; } @@ -858,14 +858,14 @@ bool PortsOrch::createBindAclTableGroup(sai_object_id_t id, sai_object_id_t &gro { SWSS_LOG_ERROR("Failed to bind VLAN %s to ACL table group %lx, rv:%d", port.m_alias.c_str(), group_oid, status); - return status; + return false; } break; } default: { SWSS_LOG_ERROR("Failed to bind %s port with type %d", port.m_alias.c_str(), port.m_type); - return SAI_STATUS_FAILURE; + return false; } }