Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mistake in wiki page 'Building' #1239

Closed
mzlogin opened this issue Apr 2, 2022 · 5 comments
Closed

mistake in wiki page 'Building' #1239

mzlogin opened this issue Apr 2, 2022 · 5 comments

Comments

@mzlogin
Copy link

mzlogin commented Apr 2, 2022

In section 'How to get the MacVim source code': https://github.com/macvim-dev/macvim/wiki/Building#how-to-get-the-macvim-source-code

$ git clone git://github.com/macvim-dev/macvim.git

should be

$ git clone git@github.com:macvim-dev/macvim.git

or some error may occurs:

The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

@eirnym
Copy link
Contributor

eirnym commented Apr 2, 2022

Hi @mzlogin

Nice catch! Could you make a PR to fix this issue?

@mzlogin
Copy link
Author

mzlogin commented Apr 3, 2022

@eirnym
Copy link
Contributor

eirnym commented Apr 3, 2022

It's a shame that GitHub still not allow to fix wikis via PRs

@mzlogin
Copy link
Author

mzlogin commented Apr 3, 2022

I agree 😢

So would you please fix it?

@ichizok
Copy link
Member

ichizok commented Apr 15, 2022

Thank you, fixed it.

@ichizok ichizok closed this as completed Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants