New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API to upload target dataset - followup actions for backend #494

Open

duncanpeacock opened this issue Jan 14, 2021 · 1 comment

Assignees

Labels

duncanpeacock commented Jan 14, 2021

Tracking task for the remaining followup tasks on the loader. These are as follows:

The upload screen should make it clear to the user that they can close the browser window and the upload will continue and that they can save the link and come back and look.
Add functionality to send an email when upload/validation is complete with any relevant details.
Fix the compound set problem (see below)

For details see: duncanpeacock/fragalysis-backend#21

duncanpeacock self-assigned this

duncanpeacock added backend bug labels

Author

duncanpeacock commented Jan 21, 2021

This is now tested.
Pull request about to be recreated.

Recommend testing both Target set loader and Compound set loader in staging/QA - as the change to the protein code also required some changes to the compound set upload.
Follow-up: Gmail email address maybe not suitable for Janssen -> Could switch to use SMTP email service and also make more parameter driven at the same time?

mwinokan added this to Fragalysis

mwinokan moved this to In production (Done) in Fragalysis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment