Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHS colour selections don't persist in snapshot (hit ID problem) #1119

Open
phraenquex opened this issue Aug 8, 2023 · 2 comments
Open

RHS colour selections don't persist in snapshot (hit ID problem) #1119

phraenquex opened this issue Aug 8, 2023 · 2 comments

Comments

@phraenquex
Copy link
Collaborator

Bug from #894: colour categories assigned to RHS selected compounds don't persist in the snapshot.

@phraenquex
Copy link
Collaborator Author

@Waztom says, this snapshot doesn't work.

@boriskovar-m2ms says:

Oh I see why. Compounds in that compounds set have no names. Actions in snapshot identify the target object by its name (in this case by tuple of dataset name and compound name). It was done in this way more than two years ago because IDs were unreliable.
I THINK we store also the ID of given object so if don’t find it by its name we can try to find it by its ID as a some kind of fallback mechanism.
And also I THINK that IDs are reliable now because this unreliability was caused by the mechanism of updating the target. Previously it worked in a way that update target was simply deleted and uploaded again. Now the target is just updated so the IDs should be stable. But @alanbchristie knows more about this than I do.
@phraenquex So IDs should be stable. Should I implement this fallback mechanism? If I start NOW then tomorrow by the end of the day it should be in staging. It's not hard change but I need to go and at least check in code a LOT of stuff (all action definitions, update functions restoring stuff, check restoring stuff when switching between snapshots in 'Project History' tab)

@phraenquex confirms to go ahead.

@phraenquex
Copy link
Collaborator Author

In fact, won't fix - will make a ticket that addresses the real problem (naming.)

@mwinokan mwinokan moved this to Invalid or duplicate - reason why given bug is invalid should be in the comments in Fragalysis May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Invalid or duplicate - reason why given bug is invalid should be in the comments
Development

No branches or pull requests

2 participants