Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulcast no longer works #1079

Closed
kekkokk opened this issue Dec 1, 2017 · 4 comments
Closed

Simulcast no longer works #1079

kekkokk opened this issue Dec 1, 2017 · 4 comments

Comments

@kekkokk
Copy link
Contributor

kekkokk commented Dec 1, 2017

After PR #1075 simulcast in chrome no longer works.

Steps to reproduce the issue:

  1. join with Chrome tab in http://localhost:3001/?simulcast=true
  2. join with another Chrome tab in http://localhost:3001/?onlySubscribe=true
  3. open http://localhost:3001/quality_layers.html

Describe the results you received:
The quality remain in the low layer

screen shot 2017-12-01 at 7 00 06 pm

Describe the results you expected:
Works as expected

Additional information you deem important (e.g. issue happens only occasionally):
Tried to also force the quality layer with remotestram._setStaticQualityLayer(1,2)

the command is ignored, still receiving low spatial layer.

Licode commit/release where the issue is happening
e6cd88b

Additional environment details (Local, AWS, Docker, etc.):
tried in localhost (OSX).
the commit before, works as expected

@lodoyun
Copy link
Contributor

lodoyun commented Dec 4, 2017

Thanks for the details and for your time testing different commits.
We're aware of the issue, it does look like there is a problem with the new generated SDP and it does not play nicely with our simulcast implementation.
We should have a solution soon.

@ChukwudiUzoma
Copy link

@lodoyun Please how do I modify the spatial and temporal layer in Chrome developer console?
room.remoteStreams.get(id)._setStaticQualityLayer(spatialLayer, temporalLayer) doesnt work. Thanks

@lodoyun
Copy link
Contributor

lodoyun commented Dec 18, 2017

@ChukwudiUzoma It should work. Check that simulcast is working and you're not using either v4 or the latest code

@ChukwudiUzoma
Copy link

@lodoyun Thanks mate, fixed it. It was just a browser problem.

@lodoyun lodoyun closed this as completed Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants