[LUR-22] Replace pallas::Scalar
as the default test field with BN256
#1018
Labels
pallas::Scalar
as the default test field with BN256
#1018
Among the instances of
CurveCycleEquipped
inproof::nova
we mostly use the one pegged topallas::Scalar
for all of our tests and as the default test workhorse. Here are the instance counts for this field:However, we're more likely to use the instance on the BN256 Scalar field as the one that will be most relevant to us:
https://github.com/lurk-lab/lurk-rs/blob/bc136099c58c1402510b949b29768d604642405b/src/proof/nova.rs#L69-L75
We should replace all instances of
pallas::Scalar
with BN256, (and correspondingly, any instances ofpallas::Vesta
with grumpkin's Scalar field), which will also help the https://github.com/lurk-lab/solidity-verifier project with test vectors.Important
We should check this does not impact benchmarks significantly (after adoption of halo2curves 0.5.0, and our integration of grumpkin-msm, we have high hopes that this might indeed be true)
Tip
Resolve #1022 at the same time to ensure non-regression.
Warning
We're picky in how we refer to those scalar fields, don't forget to also update the disallowed-methods in
.clippy.toml
This issue is not to be confused with #533 which is about application-level integration of different user-configurable fields. We're here talking about the field used by our unit tests, but we should probably set BN256 as the default nonetheless.
From SyncLinear.com | LUR-22
The text was updated successfully, but these errors were encountered: