Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove account_number and sequence #1900

Closed
faboweb opened this issue Jan 29, 2019 · 3 comments
Closed

Remove account_number and sequence #1900

faboweb opened this issue Jan 29, 2019 · 3 comments
Labels
high priority ❗ refactor

Comments

@faboweb
Copy link
Collaborator

faboweb commented Jan 29, 2019

Once cosmos/cosmos-sdk#3396 is merge

consider closing #1736
@jbibla
Copy link
Collaborator

jbibla commented Mar 11, 2019

what is the impact of this change?

@faboweb
Copy link
Collaborator Author

faboweb commented Mar 12, 2019

probably none (less code on our side). it needs to be tested if stargate increments the sequence number correctly on quick sending of multiple txs.

@faboweb
Copy link
Collaborator Author

faboweb commented Mar 14, 2019

This is actually not possible as we need both properties to create signatures.

@faboweb faboweb closed this as completed Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high priority ❗ refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@faboweb @jbibla