Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to serve sub directory in windows #7

Closed
antonheryanto opened this issue Jul 25, 2018 · 3 comments · Fixed by #8
Closed

Unable to serve sub directory in windows #7

antonheryanto opened this issue Jul 25, 2018 · 3 comments · Fixed by #8

Comments

@antonheryanto
Copy link
Contributor

antonheryanto commented Jul 25, 2018 •
edited
Loading

current version only able to serve file on root directory as the file separator in windows different with req.pathname

expected FILES mapping
{ "/img/logo.png": "public\\img\\logo.png'}
actually
{ "/img\\logo.png": "public\\img\\logo.png'}
@lukeed
Copy link
Owner

lukeed commented Jul 25, 2018 •
edited
Loading

Ah, thanks! This has to do with tiny-glob but I'll try to look into it. /cc @terkelg

@antonheryanto antonheryanto mentioned this issue Jul 25, 2018
Merged
@lukeed
Copy link
Owner

lukeed commented Jul 25, 2018

Oh whoops, nevermind :) I'm on my phone, I'll review the PR within the hour. Thanks!!

@lukeed lukeed closed this as completed in #8 Jul 25, 2018
@andreujuanc
Copy link

Thanks @antonheryanto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #7 serve sub directory in windows antonheryanto/sirv
3 participants
@andreujuanc @antonheryanto @lukeed